search

jvalen / pixel-art-react

Pixel art animation and drawing web app powered by React
https://www.pixelartcss.com/
MIT License
5.43k stars 306 forks source link

Node v16 LTS is coming soon; any plans to lock in v12 LTS for compatibility? #47

Closed bedwardly-down closed 3 years ago

bedwardly-down commented 3 years ago

According to this, V16 will go LTS on October 26. When that happens, several packages used will probably break for anyone that uses your project. Currently, I was able to get it to work fine with v14 but I haven't tested with v16 yet. I also would be willing to open a PR and do the work to help with that.

jvalen commented 3 years ago

Hi @bedwardly-down,

Thank you for presenting your initiative, feel free to create a PR for v14, not for v16 yet though. I might add some changes in the near future in the server side, so I'd rather not to change much.

Thanks again!

bedwardly-down commented 3 years ago

Can do. Any issue with me adding Nodejs v14 as a devDependency and enforcing engine strictness so that when v16 drops and systems like Gentoo or Arch force an upgrade to it, users should still be able to run without issue?

jvalen commented 3 years ago

Sure, no problem :+1:

I just merged the PR. I'm going to increase the minimum npm version though, since the "lockfileVersion": 2, is not working for a >=6.14.6 version (at least it didn't for me, I need to update to a >7.0.0)