Fix undo if setting pixel

jvalen / pixel-art-react

Pixel art animation and drawing web app powered by React

https://www.pixelartcss.com/

MIT License

5.43k stars 306 forks source link

Fix undo if setting pixel #6

Closed delebedev closed 8 years ago

delebedev commented 8 years ago

Pull request does two small things:

cleans up UndoRedo component code: library correctly handles corner cases internally
Fixes bug: if you just tick one pixel, two consecutive draw events were fired: onMouseDown and onClick, if you tap 'Undo' after it, it rolled back only one of the actions causing colored pixel to remain colored.

P.S. tests were failing for me before this change.

jvalen commented 8 years ago

Hi @garnett! Thank you for your collaboration.

I have to change the spinner behaviour a bit because the changes you made in UndoRedo. Now instead to have the first state with the loading: true I set it to false and send the SHOW_SPINNER action right after the initial state is created. Otherwise if we keep going clicking in the Undo button we would ended up with the spinner in the screen.

Thanks again!