jvandal / modwsgi

Automatically exported from code.google.com/p/modwsgi
0 stars 0 forks source link

Investigate why wsgi.file_wrapper optimisations not applied for daemon mode. #191

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Code says:

    /*
     * On some platforms, such as Linux, sendfile() system call
     * will not work on UNIX sockets. Thus when using daemon mode
     * cannot enable that feature.
     */

    if (!wsgi_daemon_pool)
        apr_os_file_put(&tmpfile, &fd, APR_SENDFILE_ENABLED, self->r->pool);
    else
        apr_os_file_put(&tmpfile, &fd, 0, self->r->pool);

There thus was obviously issues with that combination at some point.

Someone has reported though that when they switched it on for daemon mode on 
Linux that was 
now working.

This may therefore have been a restriction on older Linux kernels only.

This needs to be investigated further.

Original issue reported on code.google.com by Graham.Dumpleton@gmail.com on 5 Apr 2010 at 8:00

GoogleCodeExporter commented 8 years ago
Add a directive WSGIEnableSendfile and make use of sendfile default to Off. 
People can then enable it when they actually want it and they know sendfile 
works properly. According to:

http://httpd.apache.org/docs/2.2/mod/core.html#enablesendfile

it doesn't always work.

Original comment by Graham.Dumpleton@gmail.com on 20 Jul 2010 at 4:41

GoogleCodeExporter commented 8 years ago
Implemented in subversion trunk for mod_wsgi 4.0.

Original comment by Graham.Dumpleton@gmail.com on 31 Jul 2010 at 3:50

GoogleCodeExporter commented 8 years ago

Original comment by Graham.Dumpleton@gmail.com on 19 Mar 2012 at 10:25

GoogleCodeExporter commented 8 years ago
This was backported to 3.4.

Original comment by Graham.Dumpleton@gmail.com on 28 Mar 2013 at 6:33