jvandemo / angular-update-meta

Dynamically update meta tags for SEO purposes in your AngularJS application. Supports prerender.io.
MIT License
132 stars 36 forks source link

bower.json should be updated #12

Closed mpgn closed 8 years ago

mpgn commented 8 years ago

The file bower.json should be update to use the lastest version of AngularJS 1.4.*.

"dependencies": {
    "angular": "~1.2.21"
  },
  "devDependencies": {
    "angular-mocks": "~1.2.21",
    "angular-scenario": "~1.2.21"
  }

I tested without the dependencies with the lastest version of AngularJS, works like a charm.

jvandemo commented 8 years ago

@mpgn — The bower configuration should currently use the latest 1.x version of AngularJS.

The tilde indicates to take any subsequent minor-level or patch-level changes greater than 1.2.21, including 1.3, 1.4, 1.4.x, but not 2.x.

Are you seeing a different result?

Thanks!

mpgn commented 8 years ago

Bower will ask you if you want to use the dependancy to angular 1.2.* when you have 1.4.* every time (bower update, bower install). Of course you choose to use the 1.4.* and it's all fine.

Example, every time i use bower update bower will ask me

Unable to find a suitable version for angular, please choose one:
    1) angular#~1.2.21 which resolved to 1.2.29 and is required by angular-update-meta#1.7.0
    2) angular#>=1.2.0 <1.5.0 which resolved to 1.2.29 and is required by angular-moment#0.10.3
    3) angular#>=1.0.0 <1.5.0 which resolved to 1.2.29 and is required by angular-gravatar#0.4.1
    4) angular#^1.2.6 which resolved to 1.2.29 and is required by angular-socket-io#0.7.0
    5) angular#>= 1.0.8 which resolved to 1.2.29 and is required by angular-ui-router#0.2.15
    6) angular#>=1.2 < 1.5 which resolved to 1.2.29 and is required by angular-audio#1.7.1
    7) angular#>= 1.0.8 which resolved to 1.4.8 and is required by angular-ui-router#0.2.15

The problem ? the other package are also resolved to 1.2.29 due to angular-update-meta.

Now take a look at bower.json file of angular-ui-router https://github.com/angular-ui/ui-router/blob/master/bower.json

  "dependencies": {
    "angular": ">= 1.0.8"
  },

And now bower.json from angular-update-meta :

  "dependencies": {
    "angular": "~1.2.21"
  },

You can see the difference : >= and ~. In the doc we can have an example : https://github.com/npm/node-semver

~1.2.3 := >=1.2.3 <1.(2+1).0 := >=1.2.3 <1.3.0

Adapted to your bower.json

~1.2.21 := >=1.2.21 <1.(2+1).0 := >=1.2.21 <1.3.0

The tilde indicates to take any subsequent minor-level or patch-level changes greater than 1.2.21, including 1.3, 1.4, 1.4.x, but not 2.x.

Nop ! Angulars 1.4.* is not taken into account.

I propose you update your bower.json to :

  "dependencies": {
    "angular": ">=1.2.21 < 1.5"
  },
marcoraddatz commented 8 years ago

I just came here and wanted to open an issue, until I saw this one. Can confirm, that Angular 1.4.* must be selected manually.

Anyway: Great software and many thanks for it!

jvandemo commented 8 years ago

@mpgn — You are right!

I have corrected the version to support any version larger than 1.2.x (and below 2.x.x) and released it as v1.7.1.

Can you please verify if all is okay now?

Thanks for reporting!

/cc @marcoraddatz

mpgn commented 8 years ago

waiting for the released 1.7.1 https://github.com/jvandemo/angular-update-meta/releases

jvandemo commented 8 years ago

@mpgn — Should be there now. Can you try again? Thanks!

mpgn commented 8 years ago

I can confirm, all fine with bower update :+1:

marcoraddatz commented 8 years ago

Many thanks! Works like a charm!

jvandemo commented 8 years ago

@mpgn, @marcoraddatz — Awesome, thank you both for the confirmation!