jvandemo / generator-angularjs-library

A generator for Yeoman to generate the boilerplate for creating an AngularJS library
117 stars 33 forks source link

bower_components in karma #12

Closed ravitez closed 10 years ago

ravitez commented 10 years ago

Change 'components' to 'bower_components' in karma-unit.conf.js

jvandemo commented 10 years ago

Currently the bower directory is set to bower in the bowerrc file and thus that path is used in the karma-unit.conf.js file.

Could you please specifiy where you noticed the components directory?

Thanks!

ravitez commented 10 years ago

In karma-unit.conf.js the files array is generated as files: [ 'components/angular/angular.js', 'components/angular-mocks/angular-mocks.js'] But my bower directory is bower_components as generated by the generator. I really like the simplicity of your generator and moved some of my components from generator-angular to this.

jvandemo commented 10 years ago

Thanks for the compliment @ravitez, much appreciated.

Are you using the latest version of the generator?

It should create a bower directory for the bower files and use a bower directory in the files[] property in the karma configuration.

Here is the linkt to the most recent template: https://github.com/jvandemo/generator-angularjs-library/blob/master/app/templates/karma-unit.conf.js

Also, can you verify that you have the bowerrc file in your project directory?

Thanks again!

ravitez commented 10 years ago

I've installed the generator 2 days ago,so I think it's the latest version. And I've seen the latest version of karma-unit.conf.js to verify the same but it got generated as components instead of bower. I don't find the bowerrc file my project directory.

Do you think the generator in npm registry need to be updated ?

jvandemo commented 10 years ago

I will investigate the issue and report back.

Thank you for reporting the issue, much appreciated!

jvandemo commented 10 years ago

This should all be ok now in V2.