IAmAbszol
commented
6 years ago Hey Erik, I dove into the AddArticleTypeTransaction object where this call was being processed and found something interesting that Mitra didn't account for which led to a misleading error output.
The Barcode is valid and isn't NULL but what is NULL is the Database connection. Upon issuing the line excep.printStackTrace(); on where the error is to be handled, this comes up.
java.lang.NullPointerException at database.SQLInsertStatement.
(SQLInsertStatement.java:90) at database.Persistable.insertAutoIncrementalPersistentState(Persistable.java:663) at model.ArticleType.updateStateInDatabase(ArticleType.java:182) at model.ArticleType.update(ArticleType.java:164) at model.AddArticleTypeTransaction.processTransaction(AddArticleTypeTransaction.java:93) at model.AddArticleTypeTransaction.stateChangeRequest(AddArticleTypeTransaction.java:145) at userinterface.AddArticleTypeView$1.handle(AddArticleTypeView.java:195) at userinterface.AddArticleTypeView$1.handle(AddArticleTypeView.java:177) at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191) at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74) at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49) at javafx.event.Event.fireEvent(Event.java:198) at javafx.scene.Node.fireEvent(Node.java:8413) at javafx.scene.control.Button.fire(Button.java:185) at com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:182) at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:96) at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:89) at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:218) at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191) at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74) at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54) at javafx.event.Event.fireEvent(Event.java:198) at javafx.scene.Scene$MouseHandler.process(Scene.java:3757) at javafx.scene.Scene$MouseHandler.access$1500(Scene.java:3485) at javafx.scene.Scene.impl_processMouseEvent(Scene.java:1762) at javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2494) at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:394) at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:295) at java.security.AccessController.doPrivileged(Native Method) at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$353(GlassViewEventHandler.java:432) at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:389) at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:431) at com.sun.glass.ui.View.handleMouseEvent(View.java:555) at com.sun.glass.ui.View.notifyMouse(View.java:937) at com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at com.sun.glass.ui.win.WinApplication.lambda$null$147(WinApplication.java:177) at java.lang.Thread.run(Thread.java:748)
The first few lines give away the error
java.lang.NullPointerException at database.SQLInsertStatement.
(SQLInsertStatement.java:90) at database.Persistable.insertAutoIncrementalPersistentState(Persistable.java:663) at model.ArticleType.updateStateInDatabase(ArticleType.java:182) at model.ArticleType.update(ArticleType.java:164) at model.AddArticleTypeTransaction.processTransaction(AddArticleTypeTransaction.java:93)
So the error is really being relayed to the ArticleType object which is called by the AddArticleTypeTransaction -> myArticleType.update() call.
Suggestion We should look more at the database to completely verify a linking with the JDBC works, I saw the email noting connection problems and this is one of them. Though we now know that a new error check for a failure to connect is in order, possibly place it higher in the hierarchy of the framework to counter this problem.
eriknystrom
While attempting to add an Article Type, entered in test data of 25, Halter Top, HT. After clicking submit, the field validator stated that "25" was not numeric.
Steps to reproduce:
Expected Results: For the new Article Type to be added to the system
Actual Results: Article Type is not added, error message:
ERROR: Invalid barcode prefix: 25! Must be numerical.