search

jvcleave / ofxImGui

Use ImGui in openFrameworks
296 stars 124 forks source link

Set default flag in imgui_internal.h #127

Closed GitBruno closed 1 month ago

GitBruno commented 1 month ago

Set default to 0 (ImGuiItemFlags_None)

consistent with other defaults

Daandelange commented 1 month ago

Hi, thanks for your PR but I'm not keen of introducing custom changes to the original imgui files; maybe this is rather an ImGui API inconsistency ? Otherwise, as this change doesn't break any API, I could accept the change but it will need to be integrated in the automatic update script to make it persistent in ofxImGui, as I have done with some necessary changes for OF compatibility.

GitBruno commented 1 month ago

I added a pull request at source. There where some other issues as well. See 0d3cf29 and b1ba163

Daandelange commented 1 month ago

Hi, sorry for the delay, I'll still keep these 2 last commits (so reopening this pr). If I understood it correctly, the imgui_internal.h merge will not happen in imgui, right ?

GitBruno commented 1 month ago

That is correct so I agree with you we should not do this here.

Daandelange commented 1 month ago

Ok :) Btw, I just cherry-picked these 2 later commits ;)