jvcleave / ofxImGui

Use ImGui in openFrameworks
296 stars 124 forks source link

Update imgui_impl_glfw.cpp #129

Open PeteHaughie opened 1 month ago

PeteHaughie commented 1 month ago

Fix for Mac Intel build error error: cast of Objective-C pointer type 'id' to C pointer type 'void *' requires a bridged cast

Daandelange commented 1 month ago

Hi, thanks for finding and investigating this issue, but it's rather imgui related.
Did you submit the change to the imgui repo itself ?

I have some custom modifications with an update script, which does some necessary changes to improve compatibility with OF but I'd like to keep these minimal.

PeteHaughie commented 1 month ago

I did not as I thought it might be better served solving my own problem first. I can do that if you feel it more appropriate though.

Daandelange commented 1 month ago

To check if it's indeed an imgui bug, best would be to compile the glfw example of the imgui repo and see if you need the same change. Otherwise the bug is in the OpenFrameworks or the ofxImGui code and could be merged here.

Which versions of OpenFrameworks and operating system do you need this fix for ?

danoli3 commented 1 month ago

I'll look into this on the macOS side