Add vulkan render engine

jvcleave / ofxImGui

Use ImGui in openFrameworks

300 stars 123 forks source link

Add vulkan render engine #54

Closed tgfrerer closed 7 years ago

tgfrerer commented 7 years ago

Adds a vk engine which renders ofxImGui using the openFrameworks vulkan renderer. The headers for the new engine are excluded from GLES/GL builds, which should continue working as-is.

More on the oF vulkan renderer in the oF forum

For an example app using the oF vulkan renderer with ofxImGui, see here.

Also adds an oF logger channel to ofxImgui, which allows the openFrameworks log to be re-routed to imgui, and thus the screen.

prisonerjohn commented 7 years ago

Thanks @tgfrerer this looks great. Is there a particular reason why you put the LoggerChannel in the same file as the Helpers? I'm thinking it might be a good idea to split these up.

tgfrerer commented 7 years ago

Hey @prisonerjohn - I put it in there for it seemed the most fitting files - but no problem extracting it into its own two files, if you prefer.

tgfrerer commented 7 years ago

I've extracted the loggerchannel logic into it's own file. I've not named it more generically, i.e. "LoggerChannel" because oF has a tendency to include all files inside an addon/src into the global include search paths, and a name like "LoggerChannel" might clash with / or be already taken by another flavour of logger channel.

jvcleave commented 7 years ago

I've created a 1.50 release version prior to this merge in case there are issues with untested platforms.

prisonerjohn commented 7 years ago

How do you feel about including the shaders in the EngineVk.cpp file? Right now, they're not included in the addon, only in the example in the of-vk repo. I don't think these will need to be modified by user, so it might make sense to just have them directly in the file.

tgfrerer commented 7 years ago

good point! I'll send a PR once i get to it.