search

jvcleave / ofxImGui

Use ImGui in openFrameworks
292 stars 123 forks source link

Added convenience methods for vector<string> and Combos #80

Closed borg closed 5 years ago

borg commented 5 years ago

Life can be easier...

jvcleave commented 5 years ago

ha - i found the same thing and had it here:

https://github.com/jvcleave/ofxImGui/pull/79

borg commented 5 years ago

Funny...didn't check pending PRs before my PR about vector...would love to see those merged tho. Why live life so close to the metal? ;-)

Also, have had issues with copy & paste text and clipboard. Clipboard did not contain the right chars. Not sure you have come across those? Added some fixes related to that...but haven't tested with latest branch. They did touch the ImGui core so. https://github.com/jvcleave/ofxImGui/compare/master...borg:master

Have you tested text input & cut and paste?

jvcleave commented 5 years ago

I went ahead and merged my branch into develop with the vector combo stuff. Your approach looks nicer but I think since it is in Helpers and is an extension of ofxImGui it makes sense to keep it in the ofxImGui namespace

I haven't tested copy and paste but I am working on a project that uses the addon so I can try it when I get back to it

borg commented 5 years ago

Damned you are quick. That's awesome. Makes perfect sense to keep in ofxImGui namespace. Thanks! This is such a fantastic gui. Use it for everything these days.