search

jvcleave / ofxOMXPlayer

OpenMax accelerated video player for openFrameworks on the Raspberry Pi 0-3. Does not work with RPI4
GNU General Public License v2.0
180 stars 61 forks source link

ofxOMXPlayerEngine::scrubForward(int step) not working #130

Closed CyrCom closed 5 years ago

CyrCom commented 6 years ago

Hello, scrubForward() has two times setPaused(false) calls, unlike stepFrame(), I think there should be none.

But more importantly, it doesn't work ! It is just a copy paste of stepFrame for the moment. The clock system looks a bit rough to me, but maybe clock->step( - 1); could work ?

https://github.com/jvcleave/ofxOMXPlayer/blob/a295e721ba6d7cb7295b02b217c1d5a5ae22e765/src/ofxOMXPlayerEngine.cpp#L485

Thanks

CyrCom commented 6 years ago

I think I misunderstood what scrubForward meant, It's supposed to stepFrame and unpause. In this case, that works. (a bit redundant with stepFrame, if this last one wouldn't change pause state ?) I think it would be great to have a possibility to give stepFrame negative values, or/and have a very welcomed 'goToFrame' function. Cheers