search

jvcleave / ofxOMXPlayer

OpenMax accelerated video player for openFrameworks on the Raspberry Pi 0-3. Does not work with RPI4
GNU General Public License v2.0
180 stars 61 forks source link

Question: What does the amount of GPU split depend on? #36

Closed timonsku closed 9 years ago

timonsku commented 10 years ago

In the README it says "GPU split set to 128 (may need to be higher for larger videos)". What exactly is the determining factor here? Simply size? Meaning a 4 minute video is fine with 128MB but an hour long video needs 256MB? Or is it bitrate and or framerate that dictates the size?

jvcleave commented 10 years ago

Mainly the size of the texture

timonsku commented 10 years ago

Oh I see so if i have a higher resolution than 1920x1080 I may need more than 128MB? Is vertical/horizontal resolution the limiting factor meaning if I have 4096x60 or 60x4096 it creates a 4096x4096 texture or the total amount of pixels?

jvcleave commented 10 years ago

it allocates a texture/pixel array (if in texture mode) of the width/height of the video. The pixels are not updated unless updatePixels is called.

Pixels are needed to create the EGLImage so I don't discard them (even though you may not be using pixels) as reallocating them is expensive.

I personally haven't used larger video than 1080p - if I am using textures I stick with 720p as it usually looks good enough for my taste

timonsku commented 10 years ago

Ah I see but you don't keep all video frames in ram or anything like that which would limit the maximum video runtime?

jvcleave commented 9 years ago

No - I don't keep any video frames in RAM on the addon side

I am just getting back into updating some stuff so closing this for organization/see what to do next but feel free to continue comments if you have questions