search

jvcleave / ofxOMXPlayer

OpenMax accelerated video player for openFrameworks on the Raspberry Pi 0-3. Does not work with RPI4
GNU General Public License v2.0
180 stars 61 forks source link

ADDON_DEFINES.h conflicts with ofxNetwork #53

Closed timonsku closed 6 years ago

timonsku commented 9 years ago

The SOCKET_ERROR and INVALID_SOCKET macro seem to conflict with macros of the same name in ofxNetwork. I don't know what these macros are doing so I don't feel comfortable to start changing them. It doesn't seem like it matters that much but you may want to have a look at that.

In file included from ../../../addons/ofxNetwork/src/ofxTCPClient.h:4:0,
                 from ../../../addons/ofxNetwork/src/ofxNetwork.h:3,
                 from src/ofApp.h:57,
                 from src/ofApp.cpp:1:
../../../addons/ofxNetwork/src/ofxTCPManager.h:75:0: warning: "INVALID_SOCKET" redefined [enabled by default]
  #define INVALID_SOCKET -1
 ^
In file included from ../../../addons/ofxOMXPlayer/src/File.h:3:0,
                 from ../../../addons/ofxOMXPlayer/src/OMXReader.h:13,
                 from ../../../addons/ofxOMXPlayer/src/OMXPlayerVideoBase.h:8,
                 from ../../../addons/ofxOMXPlayer/src/OMXPlayerEGLImage.h:2,
                 from ../../../addons/ofxOMXPlayer/src/ofxOMXPlayerEngine.h:16,
                 from ../../../addons/ofxOMXPlayer/src/ofxOMXPlayer.h:7,
                 from src/ofApp.h:56,
                 from src/ofApp.cpp:1:
../../../addons/ofxOMXPlayer/src/ADDON_DEFINES.h:146:0: note: this is the location of the previous definition
 #define INVALID_SOCKET (~0)
 ^
In file included from ../../../addons/ofxNetwork/src/ofxTCPClient.h:4:0,
                 from ../../../addons/ofxNetwork/src/ofxNetwork.h:3,
                 from src/ofApp.h:57,
                 from src/ofApp.cpp:1:
../../../addons/ofxNetwork/src/ofxTCPManager.h:76:0: warning: "SOCKET_ERROR" redefined [enabled by default]
  #define SOCKET_ERROR -1
 ^
In file included from ../../../addons/ofxOMXPlayer/src/File.h:3:0,
                 from ../../../addons/ofxOMXPlayer/src/OMXReader.h:13,
                 from ../../../addons/ofxOMXPlayer/src/OMXPlayerVideoBase.h:8,
                 from ../../../addons/ofxOMXPlayer/src/OMXPlayerEGLImage.h:2,
                 from ../../../addons/ofxOMXPlayer/src/ofxOMXPlayerEngine.h:16,
                 from ../../../addons/ofxOMXPlayer/src/ofxOMXPlayer.h:7,
                 from src/ofApp.h:56,
                 from src/ofApp.cpp:1:
../../../addons/ofxOMXPlayer/src/ADDON_DEFINES.h:145:0: note: this is the location of the previous definition
 #define SOCKET_ERROR (-1)
 ^
xseignard commented 5 years ago

Hello, It's still the case with the 0.10.0_V2 release Regards