search

jvermillard / leshan

OMA Lightweight M2M java implementation - LWM2M
40 stars 25 forks source link

Fix registration update processing #13

Closed sophokles73 closed 10 years ago

sophokles73 commented 10 years ago

Only update registration properties for which a non-null value has beenprovided

jvermillard commented 10 years ago

is it a fix for issue #12 ?

sophokles73 commented 10 years ago

Julien, issue #12 should already have been fixed by a previous commit (at least the corresponding code was already present). I have added a test case, though, for validating this and have also reduced the visibility of the setters of Client in order to restrict access to the Client registration to the ClientRegistry (by means of using a ClientUpdate object)

sophokles73 commented 10 years ago

Regarding the "this." prefixing: personally, I am not that much in favor of those as well. It seems that I have been using the wrong formatting rules, i.e. not the ones contained in the project. I have changed my settings now so that any future code changes should be formatted properlly according to your settings. Sorry for that.

BTW I will be at the IoTCON in Berlin in September. I have seen that you will conduct a session there. I would be glad to get to know you in person there and also talk to Benjamin again :-)

jvermillard commented 10 years ago

no problem for the formatting. BTW can you rebase your branch? git hub complaints it cannot be merged. great news! looking forward to meet you :)

sophokles73 commented 10 years ago

I have merged master's HEAD into my branch, i.e. it should now be possible to merge in GitHub...

jvermillard commented 10 years ago

Llooks good. Thanks! I'll fix format issues, validte, tostring and other nit-picking and integrate it this afternoon.