Closed jschloman closed 10 years ago
Thanks guys! This is really massive so it will take some time to be fully reviewed. First thing to do for you, the legal annoying stuff:
So this is really a MASSIVE pull-request, thanks :)
After looking at the code with manu & simon, we would like to propose this plan:
Short plan for merging:
Long term plan after merging:
What do you think?
So this is really a MASSIVE pull-request, thanks :)
After looking at the code with manu & simon, we would like to propose this plan:
Short plan for merging:
use the core object-model(objectspec package), kill the OMA XML files remove unused class, maybe it's for a future implementation but it's really confusing rename leshan-client-standalone to leshan-client-example I think we can merge directly in the master since there is not a lot of dependency Long term plan after merging:
start using it for end-to-end client to server blackbox testing unify the API between the client and server What do you think?
I think thats a good way forward and would help the upgrade as they are incrementally pull-requested, it would make things easier
I'm all for that. I think we've already removed the unused classes (although I'm sure I missed some) and killed the OMA XML files, so that leaves renaming (and killing the OMA XML files).
:+1: Thanks! :)
I think we've covered the short-term items you asked for, but now there are conflicts that need to be resolved. I can take a look at those later today and then we should be good to go :D
I just rebased against the new master. No more conflicts :)
This is the first merge of our leshan client with the caveat that we need to resolve the last thing in leshan-client-standalone (which we will look at this evening). But we wanted to get this out to you so you can take a look at the work :)
-The Zatarians (John, Simon, Josh, Andrew)