search

jvermillard / leshan

OMA Lightweight M2M java implementation - LWM2M
40 stars 25 forks source link

Support for MultipleResourceDefinition for leshan-client #49

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hi, i have added MultipleResourceDefinition in addition to SingleResourceDefinition for the Leshan client just for the feature completeness, the usage can be seen in LeshanClientExample, for instance, powerSource Voltage, Avail.Power Sources etc. Also corrected the mockito dependency version range, because the mockito 1.10.? introduced an API break (package structure changes).

jvermillard commented 9 years ago

@jschloman or zatarians, WDYT?

jschloman commented 9 years ago

This looks good as it completes the definition support and clarifies the code. At some point we should take a look at being more restrictive on the SingleResourceDefinition constructor because, as the changed test shows, it is possible to define a SingleResourceDefinition with a MultipleLwM2mResource (which could be a bit confusing to users of the client).

jvermillard commented 9 years ago

@jschloman you should be able to merge it if you want if you do please don't create a merge commit, rebase the changes on top of the master (ff only):