search

jverzani / Mustache.jl

Port of mustache.js to julia
MIT License
128 stars 36 forks source link

Tuple indexing #127

Closed GiggleLiu closed 4 years ago

GiggleLiu commented 4 years ago

@jverzani This PR is to the branch issue_123 I just removed the if statement, we can just let it error when indexing non-indexible objects. Please confirm doing this is safe.

codecov[bot] commented 4 years ago

Codecov Report

Merging #127 into issue_123 will increase coverage by 0.92%. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           issue_123     #127      +/-   ##
=============================================
+ Coverage      81.67%   82.60%   +0.92%     
=============================================
  Files              7        7              
  Lines            524      523       -1     
=============================================
+ Hits             428      432       +4     
+ Misses            96       91       -5
Impacted Files Coverage Δ
src/context.jl 83.00% <100.00%> (-0.17%) :arrow_down:
src/tokens.jl 85.71% <100.00%> (+1.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 317f4d8...d8e67b2. Read the comment docs.