search

jverzani / gWidgets2

Rewrite of gWidgets
35 stars 9 forks source link

disable the 'Include NA' checkbox when no NA values are present in the variable. #12

Closed landroni closed 11 years ago

landroni commented 11 years ago

In gfilter(), disable the 'Include NA' checkbox when no NA values are present in the variable. Now it's always activated even when it has no function.

jverzani commented 11 years ago

Okay, but this is added but it is not synchronized with the changes in the data frame through editing. One would need to remove then add back a filter item to reflect that.

On Wed, Apr 10, 2013 at 4:25 PM, landroni notifications@github.com wrote:

In gfilter(), disable the 'Include NA' checkbox when no NA values are present in the variable. Now it's always activated even when it has no function.

— Reply to this email directly or view it on GitHubhttps://github.com/jverzani/gWidgets2/issues/12 .

John Verzani Chair, Department of Mathematics College of Staten Island, CUNY verzani@math.csi.cuny.edu

landroni commented 11 years ago

The lack of sync happens also for editing factors, numerics, etc. I need to implement a reload-filter mechanism once a merge has occurred.

One issue: The disabled includeNA happens for single choice, but not for multiple choice: In the latter it is still activated even though there is no NA.

jverzani commented 11 years ago

Thanks, missed that case.

On Thu, Apr 11, 2013 at 4:26 PM, landroni notifications@github.com wrote:

The lack of sync happens also for editing factors, numerics, etc. I need to implement a reload-filter mechanism once a merge has occurred.

One issue: The disabled includeNA happens for single choice, but not for multiple choice: In the latter it is still activated even though there is no NA.

— Reply to this email directly or view it on GitHubhttps://github.com/jverzani/gWidgets2/issues/12#issuecomment-16259086 .

John Verzani Chair, Department of Mathematics College of Staten Island, CUNY verzani@math.csi.cuny.edu