search

jverzani / gWidgets2

Rewrite of gWidgets
35 stars 9 forks source link

better handling of all-NA variables _or_ subsets #13

Closed landroni closed 11 years ago

landroni commented 11 years ago

Just checked and I think I still have trouble with this case. If you https://github.com/landroni/gWidgets2-filter/blob/master/gWidgets2-filter.R Xa$Man.trans.avail1 <- as.logical(Xa$Man.trans.avail) dffilter(Xa, TRUE)

Then display Man.trans.avail1 column. You will notice that the column class is 'logical', that checked checkboxes are displayed, and that you cannot modify these checkboxes. I think that if a variable contains only NAs, then we should display just that: NA. Inserting a string or a number or a logical in any of the cells should automatically switch the column class to 'character' or 'numeric' or 'logical'. What do you think?

  • As for all NA values, the odd thing is R will think this is a logical vector unless you do assignment with NAreal which of course no one does. I'll have to hack gtable to look at this case, but haven't done so yet.
jverzani commented 11 years ago

Okay, checked in a fix for this.