several tweaks to gfilter.R

[landroni]

Add Invert selection button to ChoiceItem and several minor tweaks (see commits). Let me know if there are issues with the code.

Thanks!

[landroni]

I also added the "focus search box" after hitting the clear button.

[landroni]

Also: make search icon NOT activatable in search box.

[jverzani]

Thanks!

[landroni]

Thanks! Wrt 9a2549b, where I can make search icon NOT activatable for gedit(..., editable=T)? I would like to make this consistent throughout gWidgets2..

[jverzani]

Yeah, actually that is GTK-specific code and should go with the gedit function in gWidgetsRGtk2. Just checked in that change to make the icons non activatable by default unless a handler is assigned.

[landroni]

Hmm, what about gcombobox(..., use_completion=T) in https://github.com/jverzani/gWidgets2RGtk2/blob/master/R/gcombobox.R ? For consistency we should add something like this:

entry$setIconActivatable("primary", FALSE)

What do you think?

[jverzani]

Yes, good idea. Just checked in the change, Thanks again. --J

[landroni]

Excellent!

One more thing: it is better UI-wise if clicking on the Clear button would also focus the input box. I think the following should do the trick for gcombobox.R:

gSignalConnect(entry, "icon-press", function(e, ...) {
    e$setText("")
    focus(e) <- TRUE
})

But I'm not perfectly sure.

[jverzani]

Okay, just checked something like this in. Thanks.

On Tue, Jul 1, 2014 at 1:11 PM, landroni notifications@github.com wrote:

Excellent!

One more thing: it is better UI-wise if clicking on the Clear button would also focus the input box. I think the following should do the trick for gcombobox.R:

gSignalConnect(entry, "icon-press", function(e, ...) { e$setText("") focus(e) <- TRUE })

But I'm not perfectly sure.

— Reply to this email directly or view it on GitHub https://github.com/jverzani/gWidgets2/pull/44#issuecomment-47683605.

John Verzani Chair, Department of Mathematics College of Staten Island, CUNY verzani@math.csi.cuny.edu

[landroni]

Perfect!