Open Magnus-Noren opened 5 months ago
Hi!
Thanks for the nice words and for reporting the issues!
I am not actively maintaining the library, but if you make a pull request we can merge it :)
Hmmm, maybe. I'm really a noob when it comes to git-related stuff, and don't know if I've ever done a pull request. Also, I contaminated the repo with some of my own stuff, for example added pybind11 as a submodule in order to make Python bindings for the parts of the library I'm using, and modified the CMakeLists.txt for that purpose. But I guess if I add those things to the gitignore, it should work? Basically, the only (small) changes I did to the original files are in fmm.hpp (in getPrecalculatedDistance) and fm2.hpp (in computeVelocitiesMap).
Hello,
Thank you for making this public. I find the library very useful in my current research.
I found a couple of small bugs when testing the code.
return distances_[idx_dist] * grid_->getLeafSize();
.I made these changes on my end, so I'm not asking you to do anything, I just thought you'd might like to know. Once again, thanks!