search

jviereck / regjsparser

Parsing the JavaScript's RegExp in JavaScript.
http://www.julianviereck.de/regjsparser/
BSD 2-Clause "Simplified" License
79 stars 20 forks source link

feat: support modifiers proposal #127

Closed liuxingbaoyu closed 2 years ago

liuxingbaoyu commented 2 years ago

ref: https://github.com/tc39/proposal-regexp-modifiers

jviereck commented 2 years ago

Thanks for all the work on this one. I plan to take a look over the weekend.

JLHwung commented 2 years ago

Can you also update https://github.com/jviereck/regjsparser/blob/e66d3d07e5d0639d14d5b599cba1c8afa58ad756/parser.d.ts#L3 ?

tjenkinson commented 2 years ago

There’s some tests for types too :)

jviereck commented 2 years ago

This looks overall good to me. Let's figure out the latest discussion about "We should parse [...]" and then this should be good to go.

jviereck commented 2 years ago

Thank you all for working on this one.

I've created a new npm release 0.9.0 of the library including this change.