jviereck / regjsparser

Parsing the JavaScript's RegExp in JavaScript.
http://www.julianviereck.de/regjsparser/
BSD 2-Clause "Simplified" License
77 stars 20 forks source link

upgrade jsesc dependency #141

Closed nmcdaines closed 1 week ago

nmcdaines commented 2 weeks ago

The current version of jsesc has an incorrect license field in the package.json that was corrected in a later release so would be nice to update to the newer version.

nicolo-ribaudo commented 1 week ago

What are the breaking changes from 0.5 to 3.0?

nmcdaines commented 1 week ago

Hi @nicolo-ribaudo, I appreciate the quick response 🙏

From a cursory look over the commit history; I am not sure the specifics of why they have bumped major commits;

Otherwise I think the main changes are removing support for older versions, see the following statement from the package README.md

As of v3.0.0, jsesc supports Node.js v6+ only.

Older versions (up to jsesc v1.3.0) support Chrome 27, Firefox 3, Safari 4, Opera 10, IE 6, Node.js v6.0.0, Narwhal 0.3.2, RingoJS 0.8-0.11, PhantomJS 1.9.0, and Rhino 1.7RC4. Note: Using the json option on objects or arrays that contain non-string values relies on JSON.parse(). For legacy environments like IE ≤ 7, use a JSON polyfill. https://github.com/mathiasbynens/jsesc?tab=readme-ov-file#support

Hope that helps 🙂

jviereck commented 1 week ago

Thanks @nmcdaines for the contribution and @nicolo-ribaudo for your comments and approval!

nmcdaines commented 1 week ago

Thanks soo much guys, I really appreciate your help 🙏

JLHwung commented 1 week ago

@jviereck Could you do an npm release? Thank you.

jviereck commented 1 week ago

Should be able to do a npm release later this evening (I am in New York).

jviereck commented 1 week ago

Published npm release: https://www.npmjs.com/package/regjsparser

Release version on GitHub: https://github.com/jviereck/regjsparser/releases/tag/v0.11.0

Feels good to be able to do open source again! Let me know if there is anything else :)