jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.07k stars 220 forks source link

Tests fail on Ubuntu, Firefox & Chromium #132

Closed jvilk closed 8 years ago

jvilk commented 8 years ago

Reproduced in an Ubuntu virtual machine. std-streams.js fails.

Investigating.

jvilk commented 8 years ago

std-streams.js fails the second time it is run with an alternative Buffer implementation: one that uses a standard array internally. When we push data onto the stream, it doesn't propagate to the callback we register.

I have no idea why this is an OS-specific bug. It does not occur on my Mac.

jvilk commented 8 years ago

Fixed in this commit:

https://github.com/jvilk/BrowserFS/commit/7f1b253db7ec3e7556ca04e7cc61977769b3d1f4

hrj commented 8 years ago

Confirming that this works for me.

However, Firefox now consistently hangs with test #321, although that might be a problem with karma or something specific to my setup. I notice a similar hang when running doppio tests with the same setup.