search

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.06k stars 215 forks source link

Tests failed on Safari Browser #179

Closed nidhimundra closed 6 years ago

nidhimundra commented 7 years ago

On running tests, all the tests pass on Chrome and Firefox, but they fail on Safari. Pasting the error below: Chrome 58.0.3029 (Mac OS X 10.12.4): Executed 704 of 704 SUCCESS (26.366 secs / 22.716 secs) Firefox 53.0.0 (Mac OS X 10.12.0): Executed 667 of 667 SUCCESS (23.917 secs / 22.596 secs) Safari 10.1.0 (Mac OS X 10.12.4) ERROR TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object. at test/harness/test.js:20219 Chrome 58.0.3029 (Mac OS X 10.12.4): Executed 704 of 704 SUCCESS (26.366 secs / 22.716 secs) Firefox 53.0.0 (Mac OS X 10.12.0): Executed 667 of 667 SUCCESS (23.917 secs / 22.596 secs) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! browserfs@1.3.0 test:karma:karma start karma.config.js` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the browserfs@1.3.0 test:karma script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! /Users/nidhi/.npm/_logs/2017-06-02T21_29_25_594Z-debug.log ERROR: "test:karma" exited with 1.`

jvilk commented 6 years ago

I opened a bug on the buffer package, which causes this error.

I don't have a good workaround right now.

jvilk commented 6 years ago

Note that this is only a problem in our test environment. Users may encounter this when using the buffer package or BrowserFS within an iframe in Safari.