Karma tests properly detect browsers with a space in their name.

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.

Other

3.06k stars 215 forks source link

Karma tests properly detect browsers with a space in their name. #189

Closed billiegoose closed 6 years ago

billiegoose commented 6 years ago

Tried this on a whim and it worked. Turns "Chrome Canary" into "ChromeCanary" and "Firefox Nightly" into "FirefoxNightly" and apparently that makes the computer happy.

Fixes #188

billiegoose commented 6 years ago

I feel like Github is lacking a way for me to respond to the "Changes requested" status. Because it still says "Changes requested" when really it should say "Requested changes have been made". I didn't think to leave a comment earlier, so this is the comment saying "That requested comment has been added and squashed! You should be good to go!"

jvilk commented 6 years ago

Thanks!