jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.06k stars 215 forks source link

"prepublish" script ignored in favor of "prepare" script in future npm #190

Closed billiegoose closed 6 years ago

billiegoose commented 6 years ago

$ npm install npm WARN prepublish-on-install As of npm@5, prepublish scripts are deprecated. npm WARN prepublish-on-install Use prepare for build steps and prepublishOnly for upload-only. npm WARN prepublish-on-install See the deprecation note in npm help scripts for more information.

Probably my smallest PR ever.

jvilk commented 6 years ago

Does this make dist run twice during npm install and npm publish? It doesn't look like there's any way around it, and the documentation is quite confusing, so I'll merge this.

billiegoose commented 6 years ago

I don't think it ran twice on npm install. I wouldn't know whether it runs twice on npm publish. I'm sure we'll hear more noise about this as npm6 and higher come along.