search

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.06k stars 215 forks source link

[WIP] Fix caught callbacks #223

Closed 1j01 closed 1 year ago

1j01 commented 6 years ago

Fixing doubled callbacks, called once to handle results and then a second time to handle an error thrown in the callback (like described here)

Yet to do: FS.ts

Need to revisit:

Fixes #221

jvilk commented 6 years ago

Sorry for letting this sit for a month!

These changes look good to me. Should I merge this in, or wait for you to finish your pass through FS?

emeryberger commented 1 year ago

Been a long time, lots of conflicts - please let me know if you are still interested in pursuing this or if we should close, thanks.

emeryberger commented 1 year ago

Closing for now. Can always re-open; just post a comment.