search

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.06k stars 215 forks source link

More CLI options for `make_http_index`? #229

Open billiegoose opened 6 years ago

billiegoose commented 6 years ago

@jvilk I ran into an issue where this line in /scripts/make_http_index.ts:

// ignore non-essential directories / files
if (ignoreFiles.indexOf(file) !== -1 || file[0] === '.') {
  return;
}

forced me to fork your script. I needed to include hidden filenames (like .eslintrc) in my index. My question for you is: should I continue using my fork (and possibly publish it) or would you be receptive to PRs adding more bells and whistles to this script?

billiegoose commented 6 years ago

I would probably start by adding support for passing in globs, and writing the result to stdout.

jvilk commented 6 years ago

Would it be acceptable to add a --include-hidden-files switch? That would be simplest to add.

billiegoose commented 6 years ago

I could live with that. 😀

james-pre commented 8 months ago

Please use https://github.com/browser-fs/core/issues/16