search

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.06k stars 215 forks source link

Promises API #230

Closed juancampa closed 9 months ago

juancampa commented 6 years ago

There's a new (albeit experimental) promise API. I just wanted to create an issue and discuss if it's worth implementing in BrowserFS. Any thoughts?

https://nodejs.org/api/fs.html#fs_fs_promises_api

Thanks for this great module btw.

jvilk commented 6 years ago

Interesting. I think I'd wait for it to become more stable; it would be a lot of churn to keep up with an experimental API.

ghost commented 5 years ago

Would you consider accepting a PR for this functionality? I think I could just shim most of the existing functions.

dbrock commented 4 years ago

Maybe time for this now? :)

RiccardoBiosas commented 1 year ago

it'd definitely be super useful, currently I have to promisify each of the node fs methods

james-pre commented 1 year ago

@RiccardoBiosas I'm currently working on converting the internals to using promises and fixing tests so after that adding a compatibility layer should be very easy.

james-pre commented 9 months ago

In case your interested @RiccardoBiosas @sixman9 @juancampa @dbrock:

Added in c8b960b