search

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.06k stars 215 forks source link

TypeError: PATH.join2 is not defined #270

Closed notiv-nt closed 8 months ago

notiv-nt commented 5 years ago

image

I thought to replace everywhere with just join, but the tests don't work on my computer, I can't check

image

notiv-nt commented 5 years ago

https://github.com/notiv-nt/BrowserFS/commit/e4bcd55a0103c38cec15a35273bd1636a2037241 Works for me

jvilk commented 5 years ago

@notiv-nt Interesting; I wonder if Emscripten changed their internal API. Could you open a PR so I can review and potentially merge?

notiv-nt commented 4 years ago

@jvilk ?

juhana commented 4 years ago

Got around this by passing a slightly modified path to the plugin.

import * as path from "path";

const BFS = new BrowserFS.EmscriptenFS(FS, { join2: path.join, ...path });
james-pre commented 8 months ago

Closing (stale). If you would like to reopen this issue, please do so by creating a new issue in the relevant repositories of @browser-fs