search

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.
Other
3.06k stars 216 forks source link

fix a recursion bug when parent directory path is '.' #312

Closed kevinramharak closed 1 year ago

kevinramharak commented 3 years ago

Fixes #273

emeryberger commented 3 years ago

LGTM. @jvilk ?

kevinramharak commented 3 years ago

I cannot seem to get the test to run locally nor will they work on the CI. This PR does not fix the issue completely but it will stop thet stack overflow

evanmcarlson commented 1 year ago

Can we get this merged?

emeryberger commented 1 year ago

@evanmcarlson can you confirm that this works? (The CI fails; it'd be nice to have that fixed.)

NovaAndrom3da commented 1 year ago

As it seems this project is now unmaintained, I forked it and have added most of the PRs that were left open, including this one :) https://github.com/Froggo8311/BrowserFS

trasherdk commented 1 year ago

@Froggo8311 If you plan to maintain your fork, you might want to rename and detach from this repository, and activate issues.

NovaAndrom3da commented 1 year ago

@trasherdk Good idea, thanks :)

emeryberger commented 1 year ago

Hi all - as long as someone is willing to verify that the PRs are correct, I am happy to merge them. @jvilk is busy with his family and can’t maintain this work right now.

james-pre commented 1 year ago

@Froggo8311 @trasherdk

As it seems this project is now unmaintained, I forked it and have added most of the PRs that were left open, including this one :)

I've become a maintainer for the project recently so BFS should be maintained.

NovaAndrom3da commented 1 year ago

@Froggo8311 @trasherdk

As it seems this project is now unmaintained, I forked it and have added most of the PRs that were left open, including this one :)

I've become a maintainer for the project recently so BFS should be maintained.

Okay, sounds good