Is there a missing dependency on `ERRNO_CODES` from emscripten?

jvilk / BrowserFS

BrowserFS is an in-browser filesystem that emulates the Node JS filesystem API and supports storing and retrieving files from various backends.

Other

3.06k stars 216 forks source link

Is there a missing dependency on `ERRNO_CODES` from emscripten? #319

Closed sbc100 closed 1 year ago

sbc100 commented 2 years ago

See https://github.com/emscripten-core/emscripten/issues/14783

I'm not familiar with how BrowserFS is used but in order to use emscripten's $ERRNO_CODES it somehow needs to be pulled in as a dependency (for library JS files this involves a __deps entry, otherwise we have the DEFAULT_LIBRARY_FUNCS_TO_INCLUDE command line setting).

My understanding is that prior to https://github.com/emscripten-core/emscripten/pull/14730, $ERRNO_CODES was likely being pulled in indirectly.

james-pre commented 1 year ago

@sbc100 BrowserFS does not use Emscripten's error codes (see api_error.ts)