search

jviquerat / beacon

A benchmark library for DRL-based flow control
10 stars 1 forks source link

KS equation #47

Open maxweissenbacher opened 1 week ago

maxweissenbacher commented 1 week ago

Hi there,

I'm very interested in using your benchmark. It may be of interest to include the Kuramoto-Sivashinsky equation in the benchmark? You can find an implementation (albeit in the torchrl library; I also have a Gym version lying around somewhere) here:

https://github.com/maxweissenbacher/charot/blob/e2fd88877b5f880b4438ed2af7353394665d7194/solver/KS_environment.py

Max

jviquerat commented 1 week ago

Hi, thanks for your message. Indeed it could be interesting I chose to implement Shkadov instead of KS since KS is actually a simplified version of the Shkadov system. We are open to PR if you want to propose a KS environment that matches the requirements of the library :) by checking your link I see that it would not be too much work to adapt it