search

jvirkki / dupd

CLI utility to find duplicate files
http://www.virkki.com/dupd
GNU General Public License v3.0
112 stars 16 forks source link

32bit not working correctly #21

Closed Freaky closed 6 years ago

Freaky commented 6 years ago

I tried setting _FILE_OFFSET_BITS=64 but it didn't change the result:

---------- test.55 --------------------
OK scan(files3): large files
OK generate report
10,11c10,11
< 0 total bytes used by duplicates:
< 112210190 total bytes used by duplicates:
---
> 4407177486 total bytes used by duplicates:
> 8589934592 total bytes used by duplicates:
FAIL generate report: verifying against output.55

error: test.55 exit code: 1
gmake[1]: *** [Makefile:119: test] Error 1
jvirkki commented 6 years ago

I haven't tried any 32bit system in a long time so not too surprised it has bit rotted away.

One one hand, 32bit support is pretty low priority at this point. On the other hand, fixing this will be a good exercise for the sake of cleaning up size assumptions in the code which is useful in its own right.

jvirkki commented 6 years ago

I have not tested the 32 bit build with any meaningful data sets, but the test suite passes cleanly now on 32 bit FreeBSD.

If anyone runs into issues with 32 bit builds, let me know.