jvm-profiling-tools / ap-loader

Packages async-profiler with binaries for all platforms in a single JAR
Apache License 2.0
130 stars 10 forks source link

Replace or drop dev.dirs:directories due to licensing issues #13

Closed jsjant closed 1 year ago

jsjant commented 1 year ago

This library uses Mozilla Public License 2.0. There are very subtle definitions on when you have to disclose your source and it's hard to use ap-loader due to this.

Would it be possible to replace this library with something like Files.createTempDirectory?

parttimenerd commented 1 year ago

I need this project at https://github.com/jvm-profiling-tools/ap-loader/blob/3f741ecaeb9a4abe2bc2e4ab50b130435ee96117/src/main/java/one/profiler/AsyncProfilerLoader.java#LL129C13-L129C13, to get the user data dir in which to store the extracted binaries in. This shouldn't be a temporary folder, as it has to persist after ap-loader exits. But we could of course use the fact that we're only supporting Linux and Mac OS and program it ourselves.

parttimenerd commented 1 year ago

We could probably implement it quite easily (using the information from the dev.dirs:directories README):

Do you want to implement this and remove the dependency?

jsjant commented 1 year ago

Yep, I'll try

parttimenerd commented 1 year ago

Fixed by the PR.

jsjant commented 1 year ago

Thank you!