jvm-profiling-tools / ap-loader

Packages async-profiler with binaries for all platforms in a single JAR
Apache License 2.0
130 stars 10 forks source link

Is it possible to support https://github.com/GoogleContainerTools/distroless? #15

Closed RoySunnySean007 closed 11 months ago

RoySunnySean007 commented 11 months ago

Dear ap-loader expert,

As we know, https://github.com/GoogleContainerTools/distroless doesn't contains shells, our ap-loader is a wrapper of async profiler which will execute the async profiler shell scripts (https://github.com/jvm-profiling-tools/ap-loader/blob/main/src/main/java/one/profiler/AsyncProfilerLoader.java#L598). Is it possible to use jattach directly to support https://github.com/GoogleContainerTools/distroless?

Thanks, Roy

parttimenerd commented 11 months ago

java -jar ap-loader.jar jattach doesn't require a shell to run.

RoySunnySean007 commented 11 months ago

Got it, thanks so much @parttimenerd ! Actually in most of cases, I need to use java -jar ap-loader.jar profiler, I will evaluate async profiler 2.10 as well.