search

jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

Solaris Profiler #111

Open nickman opened 8 years ago

nickman commented 8 years ago

I got the profiler working ok in Solaris. There's a handful of issues which I can submit a PR for such as:

  1. usleep doesn't work at all. I replaced it with an #ifdef'ed nanosleep.
  2. cmake is a bit of pain in the backside since it needs to be handheld for 32bit vs 64bit model. (or you could issue a decree that only 64 bit is supported)
  3. Need a cmake conditional for different include directories

Alternatively, rather than mess with your cmake config as it is, perhaps you would accept a simple solaris Makefile, you know, for the 3 people that might use it.

RichardWarburton commented 8 years ago

Hi @nickman,

Thanks for raising the issue. A pull request would be most appreciated. I think I would prefer to keep the build config in one build system rather than have another makefile. At least that lets us modify it in future rather than having to try and port any changes over to a different makefile.