search

jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

Retest scripts #122

Closed RichardWarburton closed 7 years ago

RichardWarburton commented 8 years ago

@neomatrix369 reported that he was getting the following errors when running scripts:

readlink: illegal option -- f
usage: readlink [-n] [file …]
FauxFaux commented 8 years ago

Since 3a7c62c2a25b2461f7681ce1b542af02e906ac52, the scripts are pretty broken on Debian/Ubuntu.

Their "alternatives" system means there's multiple layers of symlinks in front of javac:

% readlink $(which javac)
/etc/alternatives/javac
% readlink -f $(which javac)     
/usr/lib/jvm/java-8-oracle/bin/javac

This is what the readlink -f was resolving.

Additionally, the refactor broke the sed expression by moving the concatenation before the edit:

java_home=$(echo ${java_path}../ | sed 's/javac$//'.

cinquin commented 7 years ago

I didn't realize my commit broke things under Linux, but please note that we're now just back to a state where things are broken under OS X instead (as pointed out in issue #207).