jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

Fixup agent so that JVM enables DebugNonSafepoints #133

Closed nitsanw closed 8 years ago

nitsanw commented 8 years ago

This will fix the need for #132 and always do the right thing :)

RichardWarburton commented 8 years ago

I'll take your word for it, but why does CompiledMethodLoad enable DebugNonSafepoints?

nitsanw commented 8 years ago

Because: http://stackoverflow.com/questions/37298962/how-can-jvmti-agent-set-a-jvm-flag-on-startup/37306365#37306365 I tested before/after profiles and it seems to work.

nitsanw commented 8 years ago

Sorry for the noise, got the above link wrong(too many tabs, too much rushing)