search

jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

General code fix 1 #142

Closed SosoTughushi closed 8 years ago

SosoTughushi commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules: squid:S2275 - Printf-style format strings should not lead to unexpected behavior at runtime. squid:S1481 - Unused local variables should be removed. squid:S2095 - Fixed rule 'Resources should be closed.

You can find more information about the issues here: https://dev.eclipse.org/sonar/rules/show/squid:S2275 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S2095

Please let me know if you have any questions. Soso Tughushi

RichardWarburton commented 8 years ago

Hi, thanks for the PR, but some specific comments that need to be fixed before I can merge.

RichardWarburton commented 8 years ago

@SosoTughushi - I made a few inline comments on this PR. I'd be happy to merge it, but only once they are addressed.

RichardWarburton commented 8 years ago

In light of the lack of reply on these issues I'm closing this PR.