search

jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

Test enhancement #149

Closed chhsiao90 closed 8 years ago

chhsiao90 commented 8 years ago

Try build/run honest-profiler on my macbook and had found some problem.

  1. That unit test sometimes success, but sometimes failed. It seams that subprocess running InfiniteExample with profile agent that used too much CPU and cause the unit test failed. So I add agent argument: interval=100 that will decrease the cpu usage and pass the test.
  2. The binary's extension for MacOS is dylib, so I create a class named Platforms for some platform specific constant/config.
  3. Update some unit test
RichardWarburton commented 8 years ago

Thanks for the PR, I'll happily merge once the comment is addressed.

chhsiao90 commented 8 years ago

Had extracted "interval=100" as a constant!

RichardWarburton commented 8 years ago

Thanks.