Allow closing of profile tabs

PhRX commented 7 years ago

Enable close buttons on profile and profile diff tabs, and ensure that underlying resources are cleaned up when necessary.

PhRX commented 7 years ago

Feature implemented in https://github.com/PhRX/honest-profiler-fx-ui/commit/7bca26fb523c3283bc2ffbc6a3df92657532dd4e , will create PR when previous ones have been processed.

RichardWarburton commented 7 years ago

I don't understand why you can't create an independent PR. This has been discussed and explained by both @nitsanw and me.

I started reviewing the first PR and you just rejected the feedback and refused to write tests. I don't think its likely to get merged without any improvement or effort being made to address these legitimate concerns.

PhRX commented 7 years ago

Hi @RichardWarburton I understand why it might seem from the outside that I ignore the feedback, but that isn't actually true, I do take it to heart. Unfortunately, it hasn't had any visible effect yet.

There are 2 main factors/reasons :

I'm still learning git. The current PRs were intended to be independent, which is why I created a new branch for every piece, but my incorrect understanding of PRs made them linear again. My mistake, definitely. The problem here is that "undoing this" is, with my current knowledge, non-trivial. I suspect I'd have to undo all changes back to the root of the second open PR, then create branches off of the root of the first open PR, make the independent changes in a branch each, then submit a PR for each of those. I could try but I'm not comfortable doing that - mistakes on my part could mess up the project history, I think.
Time. I don't have a lot of bandwidth for this. I am planning to add tests (thinking this over this morning in fact) but it does take time, which I haven't had in recent weeks. I'm definitely not refusing to do so, and I'm sorry to hear that's what you think. The bandwidth shortage also applies to learning more about git, by the way.

Anyway, I will rollback everything and separate the changes out. After that I'll add tests.

PhRX commented 7 years ago

@RichardWarburton

I've now undone all changes in the various open PRs from me (based on http://www.claassen.net/geek/blog/2011/02/git-merge-strategytheirs.html). I recreated the changes in logical batches on separate branches, creating independent PRs for each. I hope this resolves the issue of PR independence to your satisfaction.

What cannot be helped is that the "undo" shows up as a separate new commit, so each of the new PRs contains all of the undone commits, followed by the undo commit, and the single commit containing the actual changes. I've added a comment to each PR to clarify this.

I also took care to minimize the diffs by getting rid of some formatting changes that were inadvertently introduced.

I'll see what I can do about adding tests as soon as feasible.

nitsanw commented 6 years ago

Is this still an issue?

PhRX commented 6 years ago

Yes, in the current version an opened profile cannot be closed.

jvm-profiling-tools / honest-profiler

Allow closing of profile tabs #206