search

jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

Feature : Show and hide columns in tables #213

Closed PhRX closed 7 years ago

PhRX commented 7 years ago

When there are too many columns, the table views get too cluttered. A menu was added allowing to show and hide specific columns or groups of columns.

Replaces deleted PR #197 .

PhRX commented 7 years ago

Commit 58dd0f5 reverts all previous commits from 13de748 up to and including 1e1e31e, so please ignore those commits in the PR commit list.

RichardWarburton commented 7 years ago

Thanks for the PR, Just one question - what is the license and source for the images that you've included?

PhRX commented 7 years ago

I've only added icons from the "Fugue" icon set (see http://p.yusukekamiyamane.com/), under the Creative Commons Attribution 3.0 License.

I've been meaning to put the attribution in a text file in the root dir, but I'm unsure what the name of such a file should be. Would that be "NOTICE" ?

I'll also put it in an "About" dialog if/when I get round to doing that.

RichardWarburton commented 7 years ago

Thanks for the PR.