search

jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

#224 fix + travis ci build fix for osx #225

Closed ikavalio closed 6 years ago

ikavalio commented 6 years ago

Hi,

This PR is slightly big, but it fixes several important issues with agent implementation, testing and building on travis ci.

Changes:

  1. fixes #224 .
  2. fixes osx travis builds and adds additional xcode9 tests to it.
  3. enables basic gc validation and address sanitizer for travis builds (and fixes some issues in tests reported by it).
  4. deprecates profiler config test in travis build because of the issues with address sanitizer.
  5. removes misc test since it's incorrect because of non-monotonicity of the clock.
RichardWarburton commented 6 years ago

Hi @ikavalio - thanks for the PR. It sounds great, I'm heading off on holiday very early tomorrow morning but I'll take a look next week.

nitsanw commented 6 years ago

Thanks @ikavalio !

RichardWarburton commented 6 years ago

Thanks @ikavalio for the PR and thanks @nitsanw for the review/merge.