Closed tobias-bahls closed 6 years ago
Hi @tobias-bahls, thanks very much for your research. This macro was added to support gcc-4.4 on linux as far as I know, so can you please try to replace it with:
#if __cplusplus < 201103L
# define nullptr NULL
#endif
__cplusplus
is 1 for gcc < 4.7 and should be at least 201103L after. The same is hopefully true for clang on macOS.
@ikavalio your snippet solved that issue for me
Trying to build the project on macOS 10.13.4 with the latest XCode 9.3 fails with this error:
Now, after some research I was able to pinpoint this macro definition as the cause of the error: https://github.com/jvm-profiling-tools/honest-profiler/blob/391256d84d6a9a0adcb5672e68bbc631bf3df893/src/main/cpp/concurrent_map.h#L26-L28
When removing this code, the build succeeds again. Unfortunately, I don't know enough C++ to know if this might break anything else, which is why I opted for creating this issue instead of opening a PR.