search

jvm-profiling-tools / honest-profiler

A sampling JVM profiler without the safepoint sample bias
https://github.com/RichardWarburton/honest-profiler/wiki
MIT License
1.25k stars 146 forks source link

Add a simple collector to generate flame graph data #83

Closed mbarbon closed 9 years ago

mbarbon commented 9 years ago

The pull request adds a generic class to aggregate the data (under core.collector) and trivial wrapper that can be used from the command line (under ports, I'm not sure it's the best place).

RichardWarburton commented 9 years ago

Thanks for this pull request. In general looks great, but there's a couple of issues to fix. The help won't block a merge, but the missing licensing headers probably should do.

mbarbon commented 9 years ago

Added the licensing headers and the help message (sorry for forgetting that, it should have been obvious...)

RichardWarburton commented 9 years ago

Thanks - that's great.