search

jvm-profiling-tools / perf-map-agent

A java agent to generate method mappings to use with the linux `perf` tool
GNU General Public License v2.0
1.65k stars 260 forks source link

Fixes for 22 23 #24

Closed jrudolph closed 8 years ago

jrudolph commented 8 years ago

@nitsanw I rewrote your fixes a bit. WDYT?

nitsanw commented 8 years ago

Looks good I think, I'll re-test after you submit?

On 20 Nov 2015, at 07:17, Johannes Rudolph notifications@github.com wrote:

@nitsanw I rewrote your fixes a bit. WDYT?

You can view, comment on, or merge this pull request online at:

https://github.com/jrudolph/perf-map-agent/pull/24

Commit Summary

refactoring + add comments as suggested by nitsanw in #21 generate unfolded entry for cur_method and not for top_method, fixes #22 streamline entry generation for inner and last unfolded entries, fixes #23 File Changes

M src/c/perf-map-agent.c (60) Patch Links:

https://github.com/jrudolph/perf-map-agent/pull/24.patch https://github.com/jrudolph/perf-map-agent/pull/24.diff — Reply to this email directly or view it on GitHub.

jrudolph commented 8 years ago

Thanks for confirmation.