jvm-profiling-tools / perf-map-agent

A java agent to generate method mappings to use with the linux `perf` tool
GNU General Public License v2.0
1.65k stars 260 forks source link

Add option to explicitly annotate Java frames with _[j]/_[i] #62

Closed nitsanw closed 6 years ago

nitsanw commented 7 years ago

This is not a well broken down PR, sorry. I lumped together some code cleanup/changes here:

With the new options I can have PMA generate this format, which let's BCC tools generate a usable collapased stack directly:

address size package/classname::methodname_[j];package/classname::methodname_[i]

One could argue that the right solution is a map file post processing script rather than further elaboration of the tool itself. Up for discussion.

nitsanw commented 6 years ago

@jrudolph any chance you can take a look?

nitsanw commented 6 years ago

ping?

jrudolph commented 6 years ago

@nitsanw sorry for the silence... busy months. I'll try to have a look soon.

nitsanw commented 6 years ago

@jrudolph well... at least now we know it builds!!! :-)

nitsanw commented 6 years ago

Will update the README shortly