search

jvm-profiling-tools / perf-map-agent

A java agent to generate method mappings to use with the linux `perf` tool
GNU General Public License v2.0
1.64k stars 260 forks source link

Remove nonportable GNU code #64

Closed ddevault closed 6 years ago

ddevault commented 6 years ago

It's not just __APPLE__ that doesn't support this, but POSIX as a whole. This doesn't seem necessary at all so I just removed it.

normanmaurer commented 6 years ago

@jrudolph @nitsanw I think this should also be safe to merge FTW

nitsanw commented 6 years ago

@normanmaurer it would be nice if someone rebased it to make the build pass

ddevault commented 6 years ago

Rebased.

nitsanw commented 6 years ago

Thanks for the contribution!

jrudolph commented 6 years ago

:+1: no good reason to keep those.

normanmaurer commented 6 years ago

Thanks a lot 🎉👌

Am 31.01.2018 um 16:52 schrieb Johannes Rudolph notifications@github.com:

👍 no good reason to keep those.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.